Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lesson access based on enrollment drip setting with Course Start Date set #2844

Merged
merged 8 commits into from
Jan 13, 2025

Conversation

brianhogg
Copy link
Contributor

@brianhogg brianhogg commented Jan 6, 2025

Description

Fixes #2843

If the drip setting on a lesson is "# days after enrollment" and (say) "1" days, this also changes the hover message on the Course to show when access will be granted vs. showing "This course opens on ..."

CleanShot.2025-01-06.at.9.25.36.mp4

How has this been tested?

Manually

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

HS-251918

…esson has "# days after enrollment" drip settings, use that restriction instead.
@brianhogg brianhogg requested a review from ideadude as a code owner January 6, 2025 14:28
@brianhogg brianhogg added this to the Next Available Release milestone Jan 6, 2025
…lessons wouldn't necessarily be available on the course start date if there's the enrollment drip setting in place.
@brianhogg brianhogg merged commit 80bb021 into dev Jan 13, 2025
24 checks passed
@brianhogg brianhogg deleted the allow-lesson-access-based-on--enrollment-drip-setting branch January 13, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants